Open
Conversation
Timongcraft
added a commit
to Timongcraft/VeloProtocol
that referenced
this pull request
Apr 13, 2025
chore: remove unnecessary mapping entries chore: update player loaded world api -> see PaperMC/Velocity#1541
Timongcraft
force-pushed
the
feat/loaded-world-api
branch
from
f0bd68a to
d39a003
Compare
Timongcraft
force-pushed
the
feat/loaded-world-api
branch
from
d39a003 to
0832e9d
Compare
Emilxyz
suggested changes
Oct 1, 2025
...y/src/main/java/com/velocitypowered/proxy/protocol/packet/ServerboundPlayerLoadedPacket.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/player/PlayerClientLoadedWorldEvent.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
On another note. I think it could be a good idea to remove the timeout mechanism entirely, as plugins could create a similar mechanism by e.g. scheduling in the Edit: We could note that in the javadoc if desired |
4drian3d
reviewed
Oct 30, 2025
api/src/main/java/com/velocitypowered/api/event/player/PlayerClientLoadedWorldEvent.java
Outdated
Show resolved
Hide resolved
Emilxyz
approved these changes
Oct 30, 2025
Co-authored-by: Emil <[email protected]>
chore: cleanup indentation/formatting from lib
feat(jd): add note for plugins on how to implement timeout behaviour
Timongcraft
force-pushed
the
feat/loaded-world-api
branch
from
4f86067 to
1f4b41a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, the in 1.21.4 introduced
player_loadedpacket can be utilised to send/display messages in-game without needing to guess when the player is actually in the world.This PR only implements the part when the player joins a server, and not the respawn mechanic,
this in my opinion makes sense as there's virtually no reason to fire stuff there on the proxy.
It also does not time out unlike in Paper, but plugins can implement such a behaviour themselves by scheduling a task in
ServerPostConnectEventand checkingServerConnection#isClientLoaded().Fixes: #1466