Open
Conversation
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
Co-authored-by: qodo-merge-pro[bot] <151058649+qodo-merge-pro[bot]@users.noreply.github.com>
- Update composer.json to support Filament v4 - Update DocumentationResource with v4 method signatures - Fix Alpine.js loading directives (ax-load -> x-load) - Update HelpAction for v4 compatibility - Maintain custom navigation functionality
- Add Laravel 12 support - Add Portuguese translations - Fix list styling in modals and content - Add sorting for top-level pages - Fix breadcrumbs for sub-pages - Maintain Filament v4 compatibility
- Update SubNavigationPosition import to use new Filament v4 namespace - Change DocumentationResource to use isRegistered() instead of isActive() The SubNavigationPosition class moved from Filament\Pages\SubNavigationPosition to Filament\Pages\Enums\SubNavigationPosition in Filament v4. The isActive() method doesn't exist in the base FlatfileDocumentation model, but isRegistered() provides the same functionality for determining if a document should be accessible. These two simple changes will make the CustomNavigationItemsV4 branch fully compatible with Filament v4 and eliminate the need for any workarounds.
Since this branch contains v4-specific code changes (new namespace for SubNavigationPosition), it should only support Filament v4 to prevent compatibility issues with v3 installations.
In Filament v4, the getSubNavigationPosition() method must be static, whereas in v3 it was an instance method. This change fixes the fatal error that occurred during composer install/autoload.
Changed references from Filament\Pages\SubNavigationPosition to Filament\Pages\Enums\SubNavigationPosition to reflect the updated namespace.
Replaces the use of HtmlString with Illuminate\Support\Js for generating the Alpine.js click handler payload in HelpAction. This ensures proper JavaScript encoding of the modal parameters.
Updated the default value of helpMenuRenderHook from TOPBAR_END to USER_MENU_AFTER to adjust where the help menu appears in the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also includes search and navigation customization support