[release/3.3] fix tinyformat#78843
Open
risemeup1111 wants to merge 1 commit intoPaddlePaddle:release/3.3from
Open
[release/3.3] fix tinyformat#78843risemeup1111 wants to merge 1 commit intoPaddlePaddle:release/3.3from
risemeup1111 wants to merge 1 commit intoPaddlePaddle:release/3.3from
Conversation
* fix tinyformat * for test
|
你的PR提交成功,感谢你对开源项目的贡献! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Improvements
Description
删除tinyformat里的assert,防止PADDLE_ENFORCE %个数和变量不匹配时,崩溃在assert上而没有提供PADDLE_ENFORCE更有价值的信息。
业务上发生了这种情况。但不可解释的是,assert只在DEBUG编译下才生效,为何发版的包assert会生效暂时没有找到。
通过如下方式复现问题
此后验证本PR,能够有效disable掉assert的崩溃。
但H卡Coverage,test_dygraph_sharding_stage3_for_eager等3个单测会崩溃在PrepareStridedOut中:
重命名后问题消失,可能是编译链接错函数了?无法解释。
是否引起精度变化
否
Cherry-pick of #78793 (authored by @wanghuancoder) to
release/3.3.devPR:#78793