Skip to content

[CI] validate compat-only ABI check scope#78831

Open
youge325 wants to merge 7 commits intoPaddlePaddle:developfrom
youge325:test-abi-check-compat-delete
Open

[CI] validate compat-only ABI check scope#78831
youge325 wants to merge 7 commits intoPaddlePaddle:developfrom
youge325:test-abi-check-compat-delete

Conversation

@youge325
Copy link
Copy Markdown
Contributor

@youge325 youge325 commented Apr 28, 2026

PR Category

Execute Infrastructure

PR Types

Others

Description

DO NOT MERGE. This is a temporary validation PR for ABI CI behavior.

This PR keeps the synthetic non-compat ABI deletion by moving phi::is_cpu_place(phi::Place const&) from place.cc to an inline header definition. The previous Static Check confirmed that the original checker was too broad and reported this non-compat symbol as removed.

The checker is now restricted to compat-facing C++ ABI namespaces: c10::, at::, torch::, and caffe2::. Non-compat phi::, paddle::, Python init, and Paddle C entrypoints are ignored by this compat-only checker.

Local checks:

  • bash -n ci/static_check.sh
  • python tools/test_check_abi_compatibility.py
  • python -m py_compile tools/check_abi_compatibility.py tools/test_check_abi_compatibility.py
  • git diff --check

是否引起精度变化

Copilot AI review requested due to automatic review settings April 28, 2026 13:46
@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented Apr 28, 2026

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Apr 28, 2026
@youge325 youge325 changed the title [Cpp API Compatibility] Test abi check compat delete [CI] validate ABI check on non-compat symbol deletion Apr 30, 2026
@youge325
Copy link
Copy Markdown
Contributor Author

/re-run all-failed

@youge325 youge325 changed the title [CI] validate ABI check on non-compat symbol deletion [CI] validate compat-only ABI check scope Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant