fix: use only PX4-specifc __PX4 symbol in time.c#3
Open
beniaminopozzan wants to merge 1 commit intopx4from
Open
fix: use only PX4-specifc __PX4 symbol in time.c#3beniaminopozzan wants to merge 1 commit intopx4from
beniaminopozzan wants to merge 1 commit intopx4from
Conversation
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
Member
Author
|
@dagar , do you know of any better symbol (instead of Initially I wanted to keep using
So I settled for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the of the logic to use PX4-specific time function:
#if defined(__PX4_NUTTX) || defined(__PX4_POSIX) || defined(UCLIENT_PLATFORM_NUTTX) || defined(UCLIENT_PLATFORM_POSIX)ended up always selecting PX4 variation through the
defined(UCLIENT_PLATFORM_NUTTX) || defined(UCLIENT_PLATFORM_POSIX)checks.This was spotted in eProsima#408 and its check: https://github.com/eProsima/Micro-XRCE-DDS-Client/actions/runs/19801939470/job/56760212846
This PR proposed to change the check to
#if defined(__PX4)and then let PX4 uxrce_dds_client module CMakeList.txt to add
__PX4to the submodule.