506: Story headers render broadcast date when set#515
Open
rpeterman-gp wants to merge 2 commits intowordpressfrom
Open
506: Story headers render broadcast date when set#515rpeterman-gp wants to merge 2 commits intowordpressfrom
rpeterman-gp wants to merge 2 commits intowordpressfrom
Conversation
Collaborator
|
@rpeterman-gp took another review of this PR. I think in cases where the Published date and Broadcast differ, we should show them both. If there's only one date to show, I think its the published date. So here's what I recommend: Show the pub date in the story header If the broadcast date is different, maybe something in the story footer... "This post was broadcast on {broadcast_date}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #506
To Review
yarn.yarn dev:start.