Add mechanism to control application of .nice()#268
Open
vetraskr wants to merge 1 commit intoPMSI-AlignAlytics:masterfrom
Open
Add mechanism to control application of .nice()#268vetraskr wants to merge 1 commit intoPMSI-AlignAlytics:masterfrom
vetraskr wants to merge 1 commit intoPMSI-AlignAlytics:masterfrom
Conversation
If the forceTickCount property is set on the axis, the call to .nice(...) will take the specified tickCount into account when generating the scale function for the axis.
Author
|
For posterity or in case JSBin falls over, the code for the example illustrating the buggy behaviour on the x-axis is as follows: <!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<title>JS Bin</title>
<script src="http://dimplejs.org/lib/d3.v4.3.0.js"></script>
<script src="http://dimplejs.org/dist/dimple.v2.3.0.min.js"></script>
</head>
<body>
<h2> scatter chart with axis bug demo</h2>
<div id="chartContainer">
</div>
</body>
</html> var xAxisProperty = "x_value";
var yAxisProperty = "y_value";
var data = [
{x_value: 9, y_value: 0.9},
{x_value: 10.9, y_value: 2},
{x_value: 15.6, y_value: 0.5},
{x_value: 23, y_value: 1.8}
];
var svg = dimple.newSvg("#chartContainer", 590, 400);
var myChart = new dimple.chart(svg);
var xAxis = myChart.addMeasureAxis("x", xAxisProperty);
xAxis.overrideMin = 5;
xAxis.overrideMax = 25;
xAxis.ticks = 5;
var yAxis = myChart.addMeasureAxis("y", yAxisProperty);
yAxis.overrideMin = 0.4;
yAxis.overrideMax = 2.4;
yAxis.ticks = 4;
var scatterSeries = myChart.addSeries(
[xAxisProperty, yAxisProperty, "Example Series"],
dimple.plot.bubble,
[xAxis, yAxis]);
scatterSeries.data = data;
myChart.addLegend(130, 10, 400, 35, "right");
myChart.draw();Output chart: In this output chart, the xAxis can be seen to start with a min-value below 5, despite that being explicitly set with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the forceTickCount property is set on the axis, the call to .nice(...) will take the specified tickCount into account when generating the scale function for the axis. This prevents an issue where the specified min/max value is overridden in the axis scale by the call to .nice() as the scale function is constructed.
An example of the issue may be seen here http://jsbin.com/menejiwuxu where there is a gap between the min-value of the x-axis and the origin of the axis.