-
Notifications
You must be signed in to change notification settings - Fork 1
Further UI Improvements #155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Followup to #152.
Flutter also migrated us to SPM, but it still falls back to CocoaPods. See my work at ThexXTURBOXx/flutter_web_auth_2#150.
Flutter also migrated us to SPM, but it still falls back to CocoaPods. See my work at ThexXTURBOXx/flutter_web_auth_2#150.
Less pub, less build_runner, faster runs.
74a544b to
6b25a72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements further UI improvements by updating configuration for Dart & Flutter DevTools and refining CI workflows.
- Adds a new devtools_options.yaml file with a description and documentation link.
- Updates CI configuration to include test helper files for freezed, switches dependency installation from a melos action to direct Dart commands, and adjusts the Flutter build command.
Reviewed Changes
Copilot reviewed 10 out of 28 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| devtools_options.yaml | Adds initial devtools settings configuration. |
| .github/workflows/ci.yaml | Modifies dependency installation, test file exclusions, and build commands. |
Files not reviewed (18)
- .gitattributes: Language not supported
- packages/app/ios/Runner.xcodeproj/project.pbxproj: Language not supported
- packages/app/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme: Language not supported
- packages/app/lib/main.dart: Language not supported
- packages/app/lib/src/app/bootstrap.dart: Language not supported
- packages/app/lib/src/app/create_post.dart: Language not supported
- packages/app/lib/src/app/router.dart: Language not supported
- packages/app/lib/src/app/wrapper.dart: Language not supported
- packages/app/lib/src/features/auth/presentation/auth/log_in_page.dart: Language not supported
- packages/app/lib/src/features/auth/presentation/auth/sign_up_page.dart: Language not supported
- packages/app/lib/src/features/home/presentation/home/feed.dart: Language not supported
- packages/app/lib/src/features/home/presentation/home/feed_routing_page.dart: Language not supported
- packages/app/lib/src/features/home/presentation/home/post.dart: Language not supported
- packages/app/lib/src/features/home/presentation/home/post_view_page.dart: Language not supported
- packages/app/lib/src/features/map/presentation/items/map_info_page.dart: Language not supported
- packages/app/lib/src/features/map/presentation/items/map_page.dart: Language not supported
- packages/app/lib/src/features/settings/presentation/preferences/settings_page.dart: Language not supported
- packages/app/lib/src/utils/responsive.dart: Language not supported
Comments suppressed due to low confidence (4)
devtools_options.yaml:3
- The 'extensions:' key appears without any defined extensions; if it's intended to be empty for now, consider adding a comment to clarify its purpose.
extensions:
.github/workflows/ci.yaml:149
- [nitpick] Double-check the spacing in the Flutter build command; the extra space before '--no-pub' might be unintentional.
flutter build ${{ matrix.target }} --no-pub ${{ matrix.flutter-flags }}
.github/workflows/ci.yaml:199
- Disabling 'run-bootstrap' may bypass necessary dependency bootstrapping; please verify that the subsequent 'dart pub get' step fully covers the dependency setup requirements.
run-bootstrap: false
.github/workflows/ci.yaml:250
- Ensure that setting 'run-bootstrap' to false here does not adversely affect dependency resolution, and consider documenting the rationale if intentional.
run-bootstrap: false
Thank god! To be honest, this doesn't look great yet, but it's technically correct. This should make life significantly less buggy. Note: there seems to be a bug when switching between desktop and mobile. Is that really a common situation outside of development? Ehh, hopefully not.
Maybe someday they'll be ignored like they ought to be... flutter/flutter#71762, flutter/flutter#76726, & flutter/flutter#149917.
7dc4f79 to
c3431c2
Compare
|
Note to self, update sign up page with responsive ui |
|
Looks good. I'm going to implement responsive design to sign up page then merge. There's a couple minor bugs but we can address those after state |
This is perhaps a regression, but nobody cares.
Description
This PR follows up to #152 and then some.
Closes: #80
Type of Change
Checklist
Tested on