Skip to content

Conversation

@lishaduck
Copy link
Member

@lishaduck lishaduck commented Mar 22, 2025

Description

This PR follows up to #152 and then some.

Closes: #80


Type of Change

  • ✨ New feature
  • ♻️ Code refactor
  • 💚 CI
  • 🛠️ Build configuration change
  • 🗑️ Chore

Checklist

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Fill out this template.
  • Log your hours.
  • Check that commits follow the Angular commit convention, more or less.
  • Ideally, include relevant tests that fail without this PR but pass with it (if applicable).

Tested on

  • CI
  • macOS 14

Followup to #152.
Flutter also migrated us to SPM, but it still falls back to CocoaPods.
See my work at ThexXTURBOXx/flutter_web_auth_2#150.
Flutter also migrated us to SPM, but it still falls back to CocoaPods.
See my work at ThexXTURBOXx/flutter_web_auth_2#150.
Less pub, less build_runner, faster runs.
@lishaduck lishaduck requested a review from a team as a code owner March 22, 2025 03:35
@lishaduck lishaduck self-assigned this Mar 22, 2025
@codecov
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

Attention: Patch coverage is 16.79688% with 213 lines in your changes missing coverage. Please review.

Project coverage is 23.63%. Comparing base (eb029ef) to head (5b5fb8c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/app/lib/src/app/create_post.dart 1.81% 108 Missing ⚠️
.../features/auth/presentation/auth/sign_up_page.dart 0.00% 63 Missing ⚠️
packages/app/lib/src/app/wrapper.dart 56.75% 16 Missing ⚠️
...ackages/app/lib/src/utils/enum_index_ordering.dart 20.00% 8 Missing ⚠️
packages/app/lib/src/app/router.dart 45.45% 6 Missing ⚠️
...c/features/auth/presentation/auth/log_in_page.dart 0.00% 6 Missing ⚠️
packages/app/lib/src/app/bootstrap.dart 50.00% 2 Missing ⚠️
.../lib/src/features/home/presentation/home/post.dart 0.00% 2 Missing ⚠️
packages/app/lib/src/utils/responsive.dart 66.66% 2 Missing ⚠️
Files with missing lines Coverage Δ
packages/app/lib/src/app/wrapper_page.dart 100.00% <100.00%> (+82.89%) ⬆️
.../lib/src/features/home/presentation/home/feed.dart 61.11% <ø> (ø)
...ures/home/presentation/home/feed_routing_page.dart 100.00% <100.00%> (ø)
...eatures/home/presentation/home/post_view_page.dart 0.00% <ø> (ø)
packages/app/lib/src/app/bootstrap.dart 27.77% <50.00%> (-72.23%) ⬇️
.../lib/src/features/home/presentation/home/post.dart 0.00% <0.00%> (ø)
packages/app/lib/src/utils/responsive.dart 66.66% <66.66%> (ø)
packages/app/lib/src/app/router.dart 69.38% <45.45%> (-2.36%) ⬇️
...c/features/auth/presentation/auth/log_in_page.dart 0.00% <0.00%> (ø)
...ackages/app/lib/src/utils/enum_index_ordering.dart 20.00% <20.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lishaduck lishaduck force-pushed the ui-followups branch 2 times, most recently from 74a544b to 6b25a72 Compare March 23, 2025 02:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements further UI improvements by updating configuration for Dart & Flutter DevTools and refining CI workflows.

  • Adds a new devtools_options.yaml file with a description and documentation link.
  • Updates CI configuration to include test helper files for freezed, switches dependency installation from a melos action to direct Dart commands, and adjusts the Flutter build command.

Reviewed Changes

Copilot reviewed 10 out of 28 changed files in this pull request and generated no comments.

File Description
devtools_options.yaml Adds initial devtools settings configuration.
.github/workflows/ci.yaml Modifies dependency installation, test file exclusions, and build commands.
Files not reviewed (18)
  • .gitattributes: Language not supported
  • packages/app/ios/Runner.xcodeproj/project.pbxproj: Language not supported
  • packages/app/ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme: Language not supported
  • packages/app/lib/main.dart: Language not supported
  • packages/app/lib/src/app/bootstrap.dart: Language not supported
  • packages/app/lib/src/app/create_post.dart: Language not supported
  • packages/app/lib/src/app/router.dart: Language not supported
  • packages/app/lib/src/app/wrapper.dart: Language not supported
  • packages/app/lib/src/features/auth/presentation/auth/log_in_page.dart: Language not supported
  • packages/app/lib/src/features/auth/presentation/auth/sign_up_page.dart: Language not supported
  • packages/app/lib/src/features/home/presentation/home/feed.dart: Language not supported
  • packages/app/lib/src/features/home/presentation/home/feed_routing_page.dart: Language not supported
  • packages/app/lib/src/features/home/presentation/home/post.dart: Language not supported
  • packages/app/lib/src/features/home/presentation/home/post_view_page.dart: Language not supported
  • packages/app/lib/src/features/map/presentation/items/map_info_page.dart: Language not supported
  • packages/app/lib/src/features/map/presentation/items/map_page.dart: Language not supported
  • packages/app/lib/src/features/settings/presentation/preferences/settings_page.dart: Language not supported
  • packages/app/lib/src/utils/responsive.dart: Language not supported
Comments suppressed due to low confidence (4)

devtools_options.yaml:3

  • The 'extensions:' key appears without any defined extensions; if it's intended to be empty for now, consider adding a comment to clarify its purpose.
extensions:

.github/workflows/ci.yaml:149

  • [nitpick] Double-check the spacing in the Flutter build command; the extra space before '--no-pub' might be unintentional.
flutter build ${{ matrix.target }}  --no-pub ${{ matrix.flutter-flags }}

.github/workflows/ci.yaml:199

  • Disabling 'run-bootstrap' may bypass necessary dependency bootstrapping; please verify that the subsequent 'dart pub get' step fully covers the dependency setup requirements.
run-bootstrap: false

.github/workflows/ci.yaml:250

  • Ensure that setting 'run-bootstrap' to false here does not adversely affect dependency resolution, and consider documenting the rationale if intentional.
run-bootstrap: false

Thank god!
To be honest, this doesn't look great yet, but it's technically correct.
This should make life significantly less buggy.

Note: there seems to be a bug when switching between desktop and mobile.
Is that really a common situation outside of development?
Ehh, hopefully not.
@lishaduck lishaduck force-pushed the ui-followups branch 2 times, most recently from 7dc4f79 to c3431c2 Compare March 23, 2025 23:32
@MattsAttack
Copy link
Contributor

Note to self, update sign up page with responsive ui

@MattsAttack
Copy link
Contributor

MattsAttack commented Mar 26, 2025

Looks good. I'm going to implement responsive design to sign up page then merge.

There's a couple minor bugs but we can address those after state

This is perhaps a regression, but nobody cares.
@lishaduck lishaduck added this pull request to the merge queue Apr 6, 2025
Merged via the queue into main with commit 21dc464 Apr 6, 2025
11 checks passed
@lishaduck lishaduck deleted the ui-followups branch April 6, 2025 14:55
@lishaduck lishaduck mentioned this pull request Apr 6, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants