Porting features from the Orion Bar paper branch#308
Open
drvdputt wants to merge 15 commits intoPAHFIT:devfrom
Open
Porting features from the Orion Bar paper branch#308drvdputt wants to merge 15 commits intoPAHFIT:devfrom
drvdputt wants to merge 15 commits intoPAHFIT:devfrom
Conversation
Subclasses of Fitter advertise which options are available, and choose how to implement them with their own backend. In APFitter, this comes down to selecting either LevMarLSQFitter or TRFLSQFitter
Contributor
|
Awesome, thanks for your work, and for the reminder to take a look. Apologies for the long delay. I think we should pull this apart into a few PRs. Maybe something like (starting from highest priority):
I'm a bit worried about the special modified blackbody, that seems to open a real can of worms. One idea is to maintain that as a separate repo (with appropriate warnings). |
Contributor
|
I respectfully disagree about the special modified blackbody. I think this is an important enhancement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still some loose ends since the publication of my paper (https://ui.adsabs.harvard.edu/abs/2025arXiv250705848V/abstract)
For now, to ensure reproducibility, I have created a snapshot of the code as it was used for the Orion Bar paper, in the form of a release under my fork: https://github.com/drvdputt/pahfit/releases/tag/OrionPaper2025.
I am submitting my branch as a pull request, so you can see the changes. We can decide which features we want to port over and clean it up, though it looks like it's not that much in terms of lines of code.
The most notable parts, with some relevant issues linked:
SpecialModifiedBlackbody1DAlternative dust continua #299Model.fit()invocation. Options are"lm"and"trf"(Levenberg Marquardt vs Trust-Region Reflective). TheFittersubclass has a function to advertise the available options. Relevant for No uncertainties being returned with LevMar fitter #149tauinstead. (also: adjust initial guess fortau, as it was clipped between 0 and 1 previously). Units of (modified) Blackbody amplitude #296Model. Backwards compatible with a single science pack by using*for a variable number of arguments. Modular science pack idea #298