Use elfutils to generate stack traces on linux#2027
Open
Igigog wants to merge 1 commit intoOpenXRay:devfrom
Open
Use elfutils to generate stack traces on linux#2027Igigog wants to merge 1 commit intoOpenXRay:devfrom
Igigog wants to merge 1 commit intoOpenXRay:devfrom
Conversation
Member
|
I think introducing new low-level dependency is suboptimal. Talking about desired future changes, it's waay better to use https://github.com/jeremy-rifkin/libassert. Under the hood it uses https://github.com/jeremy-rifkin/cpptrace which supports generating stack traces using several backends, so we don't need to support the code ourselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way engine stack traces are captured on Linux. Here's the comparison (commit f70e397, build type: Debug):
Before:

After:

A few important things:
elfutils-devon Alpine,libdw-devon Ubuntu andelfutils-develon Fedora (when in doubt, check CI file)