screen saver fixes #1590
Open
screen saver fixes #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have screen saver exit match entry
arntsonl
reviewed
Feb 3, 2026
Contributor
arntsonl
left a comment
arntsonl
left a comment
There was a problem hiding this comment.
I'll need to test this one, odd bug but that would be a nice easy fix. We could also potentially get rid of prevButtonState maybe?
| } | ||
| Gamepad * gamepad = Storage::getInstance().GetGamepad(); | ||
|
|
||
| if (gamepad->state.buttons || gamepad->state.dpad) { |
Contributor
There was a problem hiding this comment.
hmmm is it okay we got rid of prevButtonState? do we need to add the dpad as part of our previous state? I'll need to test this one
Contributor
Author
There was a problem hiding this comment.
My thoughts were since we only care about presses for entering screen saver, it makes sense to have the same behavior for exiting, and just disregard previous states altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have screen saver exit match entry