Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Co-authored-by: Tino Vázquez <[email protected]>

- Removed vxlan template - Updated description and user inputs for ssh cluster - Added NFS cluster - Added simple task to create datastore folder in NFS Clusters - Removed uneended tasks

Signed-off-by: Guillermo Ramos <[email protected]>

This commit replaces {{user_inputs.<input>}} strings in OpenNebula template: sections. This way common parameters for datastores and networks can be defined by the user. Change "force" message in API error message Fix onecluster show OnPrem clusters: - Improve naming and descriptions - Add method to precreate datastore folder dirs - Adjust site.yaml

* Support for "empty" NUMA nodes. Each GB200 GPU requires eight dedicated NUMA nodes for MIG support. Nodes cannot be shared with other resources (i.e. memory, CPU or other GPUs) * FEATURES. New features attributes: - GIC = General Interrupt Controller, aarch64 architectures uses GIC through APIC interface - RAS = Report host memory errors to a guest using ACPI and guest external abort exceptions - PCIHOLE64 defines MMIO space for GPU support, GB200 needs aprox 4T (4294967296 KiB) * New PCIe topology for dedicated devices. It also removes the PCI switches. Each numa node includes a pci-expander-bus with 8 pci-root ports. * PCI. New attributes for PCI passthrough devices: - ACPI_NODESET = <libvirt nodeset> NUMA nodes for ACPI - ROOT = <dedicated|shared> to attach the PCI to its own expander bus or the common one - IOMMUFD= <Yes|No> enables iommufd in the hostdev driver to propagate DMA mappings to the kernel for VM-assigned host device. - IOMMU = <Yes|No> add a dedicated iommu device. * IOMMU. New attribute to add a iommu device, includes: - MODE = <single|device> Add a single iommu device or one for each PCI passthrough device that request it - MODEL = <smmuv3|intel|amd|virtio> for the iommu device - OPTIONS = <whitespace-separated list of options> for the driver element * NUMA_NODE. New attribute, uses the node-set syntax with distance e.g. 0:254,3-15:20,23:10 - DISTANCE to set cross NUMA node distance co-author: Pavel Czerny <[email protected]>

…4026)

Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Guillermo Ramos <[email protected]>

Signed-off-by: Miguel E. Ruiz <[email protected]>

Signed-off-by: Guillermo Ramos <[email protected]>

Co-authored-by: Tino Vázquez <[email protected]>

Co-authored-by: dcarracedo <[email protected]>

- Lint - Add bash completion for oneform commands - Driver state is now stored in /var/lib/one/oneform - Improve rendering of descriptions in CLI (HTML/MD support) - Move cloud providers to oneform registry - Disable dummy driver by default - Qeury paths for driver/provider list co-authored-by: vickmp <[email protected]>

* Fix `onegroup list` for cluster quota * Fix `onegroup list` and `oneuser list` for duplicit VM_QUOTA * Linting

(cherry picked from commit 4e904acb068651b42e6a227abe505781e398cfc8)

* Removes optional chaining from the shared dependency script, as this is not supported on older node runtimes

* Add form option to install.sh * Improve CLI redacted output * Add dummy OneForm drivers to simulate operation time * Read from sensitive * Fix delete operation

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

tinova · 2026-02-09T15:53:08Z

src/client/ClientXRPC.cc

+    {
+        xmlrpc_c::fault failure = rpc->getFault();
+
+        girerr::error(failure.getDescription());


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

Potential log injection detected. Ensure all untrusted input is properly sanitized before logging. Use parameterized logging or validate input against an allow list to prevent log injection vulnerabilities. Consider using a dedicated logging library's built-in sanitization features when available. Learn more - https://cwe.mitre.org/data/definitions/117.html

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

vichansson and others added 28 commits January 22, 2026 12:47

F #7420: Fix PCI profile selection (#4021)

4246a48

Co-authored-by: Tino Vázquez <[email protected]>

F #7361: Update on-prem clusters

448044f

- Removed vxlan template - Updated description and user inputs for ssh cluster - Added NFS cluster - Added simple task to create datastore folder in NFS Clusters - Removed uneended tasks

F #7226: re-enable and fix incremental backups (#4023)

22063b3

Signed-off-by: Guillermo Ramos <[email protected]>

F #7361: Update on-prem NFS cluster to use generic DS form

04aa734

F #6778: Generate Python bindings for gRPC (#4025)

fa1a35f

F OpenNebula/one-form#62: Sunstone integration with OpenNebula Form (#…

52ccc2d

…4026)

F #7430: Add oneswap to man/build.sh (#4022)

2105293

Co-authored-by: Tino Vázquez <[email protected]>

F #7226: Debian path fixes (#4031)

a173521

Signed-off-by: Guillermo Ramos <[email protected]>

F #7465: Disable oneform clusters on creation (#4028)

8ed0d48

Signed-off-by: Miguel E. Ruiz <[email protected]>

M #-: Fix errors after testing review (#4032)

d2b5566

L #-: Lint driver.rb file

1b9ddda

F #-: Add sbin to PATH (Debian does not include it) (#4034)

8aa4acd

Signed-off-by: Guillermo Ramos <[email protected]>

B #7476: Prevent crash in xml-rpc (#4038)

9cc5468

F #6778: Fix build with grpc=no (#4029)

a29cf07

M #-: Suprress Java documentation warnings (#4024)

33dae9a

M #-: Update shared dependency handling (#4036)

a1856b0

Co-authored-by: Tino Vázquez <[email protected]>

F #7466: Changes for OneForm Sunstone integration (#4039)

eb890be

Co-authored-by: dcarracedo <[email protected]>

B #7254: Fix quotas for CLI oneuser and onegroup list (#4035) (#4040)

52d6ec7

* Fix `onegroup list` for cluster quota * Fix `onegroup list` and `oneuser list` for duplicit VM_QUOTA * Linting

B #7254: Fix copy-paste typo in oneuser and onegroup helper (#4041)

9f0c7dc

M #-: Purge install script parameters (#4042)

8aa185b

(cherry picked from commit 4e904acb068651b42e6a227abe505781e398cfc8)

B #7455: remove LEASES from updatear (#4030)

f46e795

M #-: Remove optional chaining (#4044)

295f831

* Removes optional chaining from the shared dependency script, as this is not supported on older node runtimes

M #-: Fix return code for onetemplate clone (#4047)

03e59c5

B #-: OneForm fixes (#4049)

2dccd80

* Add form option to install.sh * Improve CLI redacted output * Add dummy OneForm drivers to simulate operation time * Read from sensitive * Fix delete operation

B #7270: Add None value to disk cache (#4050)

2c8fdf2

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

tinova reviewed Feb 9, 2026

View reviewed changes

openmilanese closed this Feb 10, 2026

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Conversation

openmilanese commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

openmilanese commented Nov 29, 2021 •

edited

Loading