Conversation
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
…re_target_local.c
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
spophale
reviewed
Oct 16, 2025
Collaborator
|
@andrewkallai , I see what you are trying to do using tofrom in the absence of support for the local clause, BUT you cannot use a scalar in that case, since every device has a unique value of "x" and hence "sum", you will need a sum[TotGpus] array to store unique value for each device "i" at index "i". |
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
Co-authored-by: Swaroop Pophale <[email protected]>
spophale
reviewed
Oct 23, 2025
| return OMPVV_SKIPPED_EXIT_CODE; | ||
| } | ||
|
|
||
| int errors_arr[TotGpus] = {0}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| int errors_arr[TotGpus] = {0}; | |
| int errors_arr[TotGpus] = {0}; | |
| int sum_arr[TotGpus] = {0}; |
seyonglee
reviewed
Oct 30, 2025
spophale
approved these changes
Jan 22, 2026
Collaborator
|
@seyonglee , this PR is ready to be re-reviewed. |
spophale
reviewed
Feb 5, 2026
seyonglee
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does not compile with clang 22.0.0