fix(tLN): Make supervision removal only remove Val textContent #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I could likely do more to tidy up the tests here, let me know if that is of concern and I will update. |
Contributor
|
I would still like to have the ln removed if being created by the subscribe function. So if the private tag is in remove the ln otherwise remove the val.taxtContent. That would as far as I understand solve the issue #129, right? |
Collaborator
Author
|
Yes, let's do that, thank you for the prompt feedback 👍 |
danyill
force-pushed
the
issue-129-remove-supervision
branch
from
3b0bdf0 to
104b245
Compare
danyill
commented
Feb 26, 2025
Collaborator
Author
|
Thank you for the feedback, I have updated the PR as per your request and would, as always be grateful for a review and happy to make changes. |
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129
This PR makes supervision removal do the most minimal thing possible and seems to me to be the best way of reading the standard. It also fixes an issue where an ICT tool cannot function with our present behaviour.