Fix high memory usage during world loading#57
Merged
NotStirred merged 6 commits into1.20.4from May 31, 2025
Merged
Conversation
Member
Author
|
Subscriber list for |
CursedFlames
force-pushed
the
1.20.4_chunkLoading_optimizations
branch
2 times, most recently
from
8227754 to
5f85b3b
Compare
Member
Author
|
As discussed, further optimizations can wait until after we've bumped to the latest Minecraft version |
Member
Author
|
Nvm not ready to merge, still need to write unit tests for |
NotStirred
approved these changes
May 31, 2025
Member
NotStirred
left a comment
NotStirred
left a comment
There was a problem hiding this comment.
As discussed, many of the ChunkStatus methods don't work for both chunks+cubes, but we're fine with that until P2 and the vanilla chunkloading rewrite.
…than depending on a large list of CompletableFutures. This significantly reduces memory usage; this optimization was originally added to CC2 in 2020 by Cyclonit.
Also add a misssing dasm redirect in MixinChunkMap. Currently still fails due to excessive memory usage.
CursedFlames
force-pushed
the
1.20.4_chunkLoading_optimizations
branch
from
c4c8131 to
41035f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.