Skip to content

Implement cube packet sending and handling#51

Merged
CursedFlames merged 8 commits intoOpenCubicChunks:1.20.4from
seelderr:1.20.4_cubeSender
May 25, 2025
Merged

Implement cube packet sending and handling#51
CursedFlames merged 8 commits intoOpenCubicChunks:1.20.4from
seelderr:1.20.4_cubeSender

Conversation

@seelderr
Copy link
Contributor

This doesn't build until @CursedFlames merges #49 since I need ServerPlayer.cubePos()

Trying to do minimal amount of packet work as the 1.21 version of NeoForge packets is significantly different

@seelderr seelderr marked this pull request as ready for review May 24, 2025 18:45
@seelderr seelderr force-pushed the 1.20.4_cubeSender branch from c6ac671 to ebbcd08 Compare May 24, 2025 18:56
@seelderr seelderr force-pushed the 1.20.4_cubeSender branch from ebbcd08 to 6a5301e Compare May 24, 2025 19:01
Copy link
Member

@CursedFlames CursedFlames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@CursedFlames CursedFlames merged commit 4a0cccd into OpenCubicChunks:1.20.4 May 25, 2025
1 check passed
@seelderr seelderr deleted the 1.20.4_cubeSender branch May 28, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants