Skip to content

Update workflows to always upload test report even on catastrophic failure#50

Merged
CursedFlames merged 2 commits intoOpenCubicChunks:1.20.4from
NotStirred:1.20.4_updated_workflows
May 23, 2025
Merged

Update workflows to always upload test report even on catastrophic failure#50
CursedFlames merged 2 commits intoOpenCubicChunks:1.20.4from
NotStirred:1.20.4_updated_workflows

Conversation

@NotStirred
Copy link
Member

I'm not actually 100% sure this will work, gh actions is still a mystery to me.

stack overflow suggests this will work though

@NotStirred NotStirred requested a review from CursedFlames May 23, 2025 14:09
@CursedFlames
Copy link
Member

By the sounds of that stackoverflow thread, if: always() will run even if the build is manually cancelled, whereas if: success() || failure() will not run on manual cancellations. Thoughts?

@NotStirred
Copy link
Member Author

Yeah I was unsure about the behaviour we wanted honestly, I guess if a test has already failed and you want the results you can cancel and download straight away.

But that depends on whether gradle generates reports as each test runs or only once all have completed.

@CursedFlames CursedFlames merged commit bad813c into OpenCubicChunks:1.20.4 May 23, 2025
1 check passed
@NotStirred NotStirred deleted the 1.20.4_updated_workflows branch May 23, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants