Merged
Conversation
NotStirred
reviewed
May 3, 2025
Member
There was a problem hiding this comment.
lgtm minor things
a bunch of methods aren't tested, I'll PR this pr adding the ones I think we should test.
Here are the methods that aren't tested and I don't think we can / need to test:
(lmk if you agree)
I'm adding tests now:
hasChunkcc_hasCubegetChunkNowcc_getCubeNow
Should test P2+:
blockChangedcc_blockChangedsetSpawnSettingsonLightUpdateticktickChunks+getFullChunk(only called in ticking)cc_tickChunkscc_getCubeForLightingcc_onLightUpdatecc_onTickChunksisPositionTicking
Trivial:
getTickingGeneratedsavegetPendingTasksCountgetGeneratorStateaddEntityremoveEntitygetChunkDebugDatacc_getChunkDebugDatagetChunkFutureexists, it's only used in debug code..?cc_getCubeFuturesetViewDistancesetSimulationDistanceaddRegionTicketgetMainThreadProcessorgatherStatschunkScannergetLightEnginemoveaddRegionTicketremoveRegionTicketcc_addRegionTicketcc_removeRegionTicketremoveTicketsOnClosingpollTaskbroadcastgetLastSpawnStategetDataStoragebroadcastAndSendclosegetLightEnginecc_updateChunkForcedupdateChunkForcedgetLoadedChunksCountgetPoiManagergetGenerator
NotStirred
requested changes
May 3, 2025
...bicchunks/cubicchunks/integrationtest/server/level/IntegrationTestCubicServerChunkCache.java
Outdated
Show resolved
Hide resolved
Added for: vanilla, chunks in cubic context, and cubes.
Co-authored-by: Tom Martin <[email protected]>
NotStirred
approved these changes
May 13, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.