Closed
Conversation
Contributor
Author
|
@soxofaan does this design match with what we discussed yesterday? |
Contributor
Author
|
@soxofaan failing unit tests seem to be unrelated? |
Member
|
yes failing tests are already failed on master (#715 ), so I would merge master in your branch |
Contributor
Author
|
@soxofaan there we go |
Collaborator
Contributor
Author
|
From my end, it's ready to merge. Uncertain if it will make a difference for LCFM. There we would need to pre-create a queue of created jobs |
soxofaan
reviewed
Jan 31, 2025
soxofaan
pushed a commit
that referenced
this pull request
Jan 31, 2025
… jobs (this is a squashed commit based on #711)
Member
|
squashed and merged in 6dbf2f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.