Skip to content

Ogc 2853 agency new UI#2324

Open
BreathingFlesh wants to merge 19 commits intomasterfrom
ogc-2853-agency-new-ui
Open

Ogc 2853 agency new UI#2324
BreathingFlesh wants to merge 19 commits intomasterfrom
ogc-2853-agency-new-ui

Conversation

@BreathingFlesh
Copy link
Contributor

@BreathingFlesh BreathingFlesh commented Feb 3, 2026

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Agency: New UI

TYPE: Feature
LINK: OGC-2853

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have added an upgrade hint such as data migration commands to be run
  • I have updated the PO files
  • I have tested my code thoroughly by hand
    • I have tested styling changes/features on different browsers
    • I have tested javascript changes/features on different browsers
  • I have added tests for my changes/features

@linear
Copy link

linear bot commented Feb 3, 2026

@Tschuppi81
Copy link
Contributor

Tschuppi81 commented Feb 3, 2026

When adding a new organization, the send/save button is at the bottom
image

  • add user
image
  • form change url, also misses breadcrumbs
image

@Tschuppi81
Copy link
Contributor

Tschuppi81 commented Feb 3, 2026

More views with send/save button at the bottom

  • organization move
Screenshot from 2026-02-03 17-00-42
  • organization sort
Screenshot from 2026-02-03 17-00-57
  • organization change url
Screenshot from 2026-02-03 17-01-11
  • organization create pdf
Screenshot from 2026-02-03 17-01-28
  • user profile
image

@Tschuppi81
Copy link
Contributor

Personally, I think the whole person card should be 'clickable' not just the title/name of the card
Screenshot from 2026-02-03 17-14-12

@Tschuppi81
Copy link
Contributor

Survey url change does not work, e.g. http://localhost:8080/onegov_agency/lu/survey/test/change-url
image

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 67.56757% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.33%. Comparing base (09587de) to head (267b336).
⚠️ Report is 25 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/onegov/agency/views/agencies.py 39.13% 14 Missing ⚠️
src/onegov/org/cli.py 27.27% 8 Missing ⚠️
src/onegov/town6/views/usermanagement.py 50.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/agency/app.py 97.77% <100.00%> (-0.05%) ⬇️
src/onegov/agency/custom.py 100.00% <100.00%> (ø)
src/onegov/agency/forms/agency.py 97.22% <ø> (-0.04%) ⬇️
src/onegov/agency/forms/membership.py 97.56% <ø> (-0.12%) ⬇️
src/onegov/agency/layout.py 94.92% <100.00%> (+0.11%) ⬆️
src/onegov/agency/request.py 100.00% <100.00%> (ø)
src/onegov/agency/theme/agency_theme.py 100.00% <100.00%> (ø)
src/onegov/agency/views/people.py 94.59% <ø> (-0.11%) ⬇️
src/onegov/agency/views/settings.py 100.00% <100.00%> (ø)
src/onegov/town6/app.py 95.34% <100.00%> (+0.13%) ⬆️
... and 4 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09587de...267b336. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants