[wpmlpb-665] Avada: translatable form notifications #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It looks good @dgwatkins, but I'll give my approval later, so we avoid to mistakenly merge/deploy at the wrong moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will merge these XML changes with WPML 4.10.
This will give time to existing Avada users to update to 4.9 which will apply this XML configuration via code.
When we release 4.10, all users should have the updates required for this XML to work and we can remove the code thats applies this configuration and use the XML instead.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-665