[wpmlpb-737] Elementor: add missing configurations #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgwatkins
force-pushed
the
wpmlpb-737
branch
from
5ecf1de to
a171f04
Compare
Collaborator
Author
|
@strategio These are the builtin widgets that didn't have a configuration yet. As you can see, some of them are empty. This is because they have translatable controls that we don't want to translate. For example, the Others have fields that I have not been able to set in the UI, maybe leftovers? maybe unreleased features? (ie: My question is, is it acceptable to add those widgets here with no fields? |
strategio
reviewed
Nov 12, 2025
Member
strategio
left a comment
strategio
left a comment
There was a problem hiding this comment.
@dgwatkins, yes I think it's valid to have empty widget configuration. At least it will ensure we won't attempt to guess a config with our new mechanism.
dgwatkins
force-pushed
the
wpmlpb-737
branch
from
a171f04 to
d30fa35
Compare
Collaborator
Author
|
merged and deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://onthegosystems.myjetbrains.com/youtrack/issue/wpmlpb-737