Update SDKs #2652
Merged
Update SDKs #2652
+156
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Mar 19, 2025
| <PackageReference Include="Newtonsoft.Json" /> | ||
| <PackageReference Include="System.Collections.Immutable" /> | ||
| <PackageReference Include="System.Composition" /> | ||
| <PackageReference Include="System.ValueTuple" /> |
Member
Author
There was a problem hiding this comment.
Got build warnings that System.ValueTuple was unnecessary and could be removed.
JoeRobich
force-pushed
the
dev/jorobich/update-sdks
branch
from
d887921 to
21f6d99
Compare
JoeRobich
commented
Mar 25, 2025
JoeRobich
force-pushed
the
dev/jorobich/update-sdks
branch
from
641ecb5 to
9d5e790
Compare
dibarbet
approved these changes
Aug 5, 2025
| MicrosoftBuildLocator.RegisterMSBuildPath(instance.MSBuildPath); | ||
| // Find and load NuGet assemblies if msbuildPath is in a VS installation. This mimics what | ||
| // Microsoft.Build.Locator does when calling RegisterInstance. | ||
| var nugetPath = Path.GetFullPath(Path.Combine(instance.MSBuildPath, "..", "..", "..", "Common7", "IDE", "CommonExtensions", "Microsoft", "NuGet")); |
Contributor
There was a problem hiding this comment.
What changed here that made it break on the SDK upgrade?
Member
Author
There was a problem hiding this comment.
So kept having runs on Windows where project loading was failing due to a missing NuGet method seeing this issue - dotnet/msbuild#6289. I am certain the circumstances are different but then I looked at msbuildlocator which has this behavior on .NET Framework when calling RegisterInstance. I just copied it over to work here. I can likely remove it, but am deferring until I remove net472 as a build target.
JoeRobich
added a commit
that referenced
this pull request
Aug 5, 2025
Builds on the SDK update PR #2652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.