Skip to content

fix exception with null sdk version #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
corngood wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix exception with null sdk version #2058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OmniSharp.MSBuild/ProjectLoadListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ private static HashedString GetProjectId(ProjectLoadedEventArgs args)

private static HashedString GetSdkVersion(ProjectLoadedEventArgs args)
{
return _tfmAndFileHashingAlgorithm.HashInput(args.SdkVersion.ToString());
return _tfmAndFileHashingAlgorithm.HashInput($"{args.SdkVersion}");
Copy link
Member

@filipw filipw Dec 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could just return a null I think
however, a better question is if we should allow to start without dotnet on the path at all.
There would be other things that will fail without it e.g. auto restore or test adapter

}

private static HashedString GetSessionId(ProjectLoadedEventArgs args)
Expand Down