fix dumpkeyset #4176
Merged
fix dumpkeyset #4176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4176 +/- ##
===========================================
+ Coverage 34.92% 57.20% +22.28%
===========================================
Files 459 459
Lines 55830 55831 +1
===========================================
+ Hits 19498 31940 +12442
+ Misses 32869 19094 -13775
- Partials 3463 4797 +1334 |
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
joshuacolvin0
added a commit
that referenced
this pull request
Dec 31, 2025
port: fix dumpkeyset (#4176)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable chunked-store in datool dumpkeyset so it no longer requires a signer and can compute keyset hashes directly from configured backends.
If we don't disable it, this command will throw error
panic: chunked store requires a valid signer for replay protection; cannot use nil signerReplace 4175