Fixes for all keyword parameters and attribute access #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use LUA 5.1 if 5.2 doesn't exists on the system
Update to bastibe
Fix calls with only names arguments and reading attributes
Updated ppa repo links. Added Python 3.8 to test matrix.
built with rather than guessing it in the source. This should also fix issue #74.
Python38 and fix for issue #74
Added Lua 5.2 to test matrix.
Update README.md to make code blocks render correctly on GitHub
…object_call. Captured any error string from the called function and added it to the lua error being thrown.
…rue/Py_False, without incrementing the reference. Fixed it by calling LuaConvert
Modified function error handling after calling python function in py_…
Made changes to CMakeLists.txt to work with Python3 and Python2
Improve compatibility with LuaJIT
I add syntax highlighting to all examples. I cared to always choose the right one (Lua/Python)
Add syntax highlight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed these kind of calls in lua (only named arguments, none numbered:
plt.set{title='hi', xaxis='there'}
and this one (reading a computed property from python):
dicomimage.pixel_data.
Please merge, just few lines in pythoninlua.c
Marcel