Fix isAdminUserMiddleware ignoring DB errors#399
Open
alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
Open
Fix isAdminUserMiddleware ignoring DB errors#399alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
alex-vydrin wants to merge 1 commit intoOWASP:masterfrom
Conversation
…redirecting Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isAdminUserMiddlewareinapp/routes/session.jscallsuserDAO.getUserByIdwith a callback that receives(err, user)but never checkserr. If the database is down or returns an error, the middleware silently treats the request as "not admin" and redirects to/logininstead of surfacing the actual error.if (err) return next(err);check in the callback before evaluating the user, consistent with the error-handling pattern used elsewhere in the same file (e.g., line 267).Test plan
next(err)and Express's error handler is invokednpm test)Made with Cursor