i.sentinel.mask: fix no clouds/shadow overlap error#1166
Open
griembauer wants to merge 1 commit intoOSGeo:grass8from
Open
i.sentinel.mask: fix no clouds/shadow overlap error#1166griembauer wants to merge 1 commit intoOSGeo:grass8from
griembauer wants to merge 1 commit intoOSGeo:grass8from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
i.sentinel.mask, I encounteredwhich corresponds to
Tested:
I assume this occurs when the maps
cloudsanddark_pixelsdon't have any overlap. They contain only the values NoData and 0, so due to the-nflag,r.statsdoes not give any information on category combinations if the only occuring category combinations contain at least one NoData.This PR fixes this issue, but I am not sure if this is consistent with the remaining logic of the module