Skip to content

Comments

Formatting pr#263

Open
ReidP-source wants to merge 9 commits intodevfrom
formatting-pr
Open

Formatting pr#263
ReidP-source wants to merge 9 commits intodevfrom
formatting-pr

Conversation

@ReidP-source
Copy link
Collaborator

All compiles pre-PR. I'll add a script to loom-ci that will allow you to compile all the examples locally with arduinoIDE's compiler.

PR Includes

Hypnos voltage check method that will be expanded on to change Hypnos behavior based on voltage.
Formatted Files
Format config
Updated .gitignore
GitHub workflow tested locally with act. Will monitor if it's working properly with future PR's.

Expected behavior for workflow

  • On PR to dev or main (mostly dev) clang-format will run with config.
  • Changes will be made if the initial commit did not run formatting prior to PR.
  • New commit will be made to the PR with the updated formatting.
  • Formatting should never break the program but it is recommended to run formatting prior to commit.

Step 1 of #251
Instructions for running the compile and format script locally will be added to https://github.com/OPEnSLab-OSU/ci-loom

Experimenting with a workflow to compile the examples. Will get that added after we know this is working.

Updated GitHub Actions workflow to improve checkout and commit logic.
SeamusTappert and others added 3 commits February 19, 2026 12:16
Successful error codes can be 0 for no changes or 1 for changes. Any other error code should result in a failure. 

Adjusted -euo pipefail error check to allow 1 and 0. 

refs #265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants