Conversation
smstone0
added
enhancement
mwirikia
reviewed
Apr 17, 2026
| await expect(suggestionLink).toBeVisible(); | ||
| await expect(suggestionLink).toHaveAttribute( | ||
| 'href', | ||
| 'https://github.com/ONSdigital/keh-tech-radar-submissions' |
Contributor
There was a problem hiding this comment.
think this should be mocked and deterministic, rm the link to actual true link
TotalDwarf03
approved these changes
Apr 20, 2026
delterr
approved these changes
Apr 21, 2026
mwirikia
reviewed
Apr 22, 2026
| import { nodeBlipCases } from './data/nodeBlipCases'; | ||
| import { reviewPositionCases } from './data/reviewPositionCases'; | ||
| import { directorateData } from './data/directorateData'; | ||
| import { getTechRadarSubmissionsUrl } from '../../../frontend/src/constants/radarConstants'; |
Contributor
There was a problem hiding this comment.
think we need to remove the radarConstants now we are reading the values from SM
mwirikia
reviewed
Apr 22, 2026
| import { directorateData } from './data/directorateData'; | ||
| import { getTechRadarSubmissionsUrl } from '../../../frontend/src/constants/radarConstants'; | ||
|
|
||
| const techRadarSubmissionsUrl = getTechRadarSubmissionsUrl(process.env); |
Contributor
There was a problem hiding this comment.
mock the VITE_TECH_RADAR_SUBMISSIONS_URL to make it deterministic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR:
Related Issues
KEH-2140
Testing
Check the signpost message at the top of the radar page and view the updated message under the timeline section.
Checklist
Exemptions
Additional Notes