Open
Conversation
|
|
Contributor
Author
|
@lefessan What's your take on this PR? |
nberth
reviewed
Mar 5, 2024
Collaborator
nberth
left a comment
nberth
left a comment
There was a problem hiding this comment.
I've probably missed many aspects, and don't even know how to test this (yet). But that could be an interesting addition indeed.
| opam init | ||
| # note autofonce-lib currently needs to be manually installed, see https://github.com/OCamlPro/superbol-studio-oss/issues/79 | ||
| opam install autofonce_lib | ||
| opam install ./opam/*.opam -y--deps-only |
Collaborator
There was a problem hiding this comment.
I think here that would now be make dev-deps in place of the two calls to opam install.
| - name: build superbol-free (LSP) | ||
| command: | | ||
| gp sync-await opam-prepare | ||
| make superbol-free |
Collaborator
There was a problem hiding this comment.
Now make superbol-lsp-server
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this likely isn't "final" this seems to be the minimal needed setup.
I've started locally but recognized fast, that this won't work as the whole vsix part needs node 14 because of its dependencies (stable Debian distributes node 12, which I even had not installed) and the LSP part seems to need a complete ocaml environment.
Much nicer to have that online available.
I'll likely update that later and possibly add a link to use that to a hacking file (currently working on the README).