[18.0][web_widget_dropdown_dynamic][FIX]: value dissappearing afetr losing …#3496
Open
[18.0][web_widget_dropdown_dynamic][FIX]: value dissappearing afetr losing …#3496
Conversation
…focus when used in list view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…focus when used in list view
I was using a list view of one2many inside a form with selection field using
web_widget_dropdown_dynamicwidget noticing strange behavior: selecting an option works fine but when the field loses focus, the value dissappears. However it is saved into the database. When loading the form the value is not there either, onl;y when clicking the field.The web.SelectionField template has two rendering paths:
FieldDynamicDropdownextendsComponentdirectly (notSelectionField), soget string()was never inherited. When an editable list row loses focus and switches back to readonly display,this.stringis undefined — OWL renders an empty span. The value is still in the record (hence "saved into database later"), but the readonly display renders blank.Fix: Added
get string()toFieldDynamicDropdownthat looks up the label for the current value fromthis.specialData, matching the same logic asSelectionField.stringbut working with the dynamically-fetched options. With the help of Claude added a test for this as well.