[18.0][FIX] auth_jwt: mute noisy Odoo test patch checker#899
Conversation
|
Hi @sbidoul, |
|
@StefanRijnhart I had done #897 yesterday, do we still need this? |
|
@sbidoul Yes, because after #897, the logs are still littered with |
|
Ah yes, I see. Do we know the purpose of that specific log and why it logs a stack trace at INFO level? I could not immediately find the explanation in the upstream PR. |
|
If I understand correctly, the purpose is to register the file and method as a known originator of patches. The goal of the code is to point out unregistered (and as such, illegitimate) patches in tests. I would normally set SETATTR_SOURCES in tests, but this one fires unconditionally whenever post tests are run on a database with this module installed. |
|
Wait, this won't do. It raises a runtime warning. 2026-02-20 10:42:04,254 157722 ERROR odoo odoo.tests.common: Importing test framework, avoid importing from business modules and when not running in test mode Refactored to mute the logger in the patching method. |
c9f10cf to
714196e
Compare
714196e to
fb0eea0
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at a12f4c8. Thanks a lot for contributing to OCA. ❤️ |
See odoo/odoo#247151