[16.0] [ADD] cross_connect_client#735
Merged
OCA-git-bot merged 8 commits intoOCA:16.0from Jun 3, 2025
Merged
Conversation
paradoxxxzero
force-pushed
the
16.0-add-cross_connect_client
branch
4 times, most recently
from
c3e5a28 to
4fa1a2c
Compare
paradoxxxzero
force-pushed
the
16.0-add-cross_connect_client
branch
from
4fa1a2c to
c833e56
Compare
florian-dacosta
approved these changes
Apr 2, 2025
Contributor
florian-dacosta
left a comment
florian-dacosta
left a comment
There was a problem hiding this comment.
LGTM test + code review.
I'd added some not blocking remarks, but is good enough to be merged already IMO.
|
|
||
| @property | ||
| def _server_env_fields(self): | ||
| return {"api_key": {}} |
Contributor
There was a problem hiding this comment.
I think we should override the unlink method to delete the groups and menu before deleting the cross connect server.
(Even without changing the action_disable method, I guess the cross.connect.server could be deleted while enabled)
Contributor
Author
There was a problem hiding this comment.
Can’t we cascade these?
We want to avoid deletion of the group because we would then loose all users configured on it. So we prefer to remove the link between the cross connect server and the group instead
…-ref [REF] avoid groupe deletion + simplify name management
florian-dacosta
approved these changes
Apr 3, 2025
Member
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 75e8eb2. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module allows an odoo instance users to connect directly on another odoo instance
where the module
cross_connect_server(#734) is installed.