[17.0][FIX] base_report_to_printer: Print ZPL without downloading#441
Open
arantxa-s73 wants to merge 2 commits intoOCA:17.0from
Open
[17.0][FIX] base_report_to_printer: Print ZPL without downloading#441arantxa-s73 wants to merge 2 commits intoOCA:17.0from
arantxa-s73 wants to merge 2 commits intoOCA:17.0from
Conversation
arantxa-s73
force-pushed
the
17.0-fix_print_without_downloading_ZPL
branch
2 times, most recently
from
9d67e37 to
51465bf
Compare
ferran-S73
force-pushed
the
17.0-fix_print_without_downloading_ZPL
branch
from
51465bf to
4379353
Compare
Contributor
|
This PR has the |
|
@OCA/tools-maintainers Please, can you review/merge this PR? |
thomaspaulb
changed the title
|
@Reyes4711-S73 Can you, this time, let this run in production a couple of weeks before we call it a win? |
|
@thomaspaulb We tested this in several customers (dev and production environments), so I can call it a win. |
arantxa-s73
force-pushed
the
17.0-fix_print_without_downloading_ZPL
branch
from
4379353 to
1a59714
Compare
arantxa-s73
force-pushed
the
17.0-fix_print_without_downloading_ZPL
branch
from
1a59714 to
2aa4cba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a ZPL report, configured to print and with the default printer set, when printing it, in addition to sending it to the corresponding printer, it was downloaded to the device. With the change to pr, we eliminated the download to the device.