[18.0][FIX] base_report_to_printer: neutralization scripts#433
Open
ferran-S73 wants to merge 1 commit intoOCA:18.0from
Open
[18.0][FIX] base_report_to_printer: neutralization scripts#433ferran-S73 wants to merge 1 commit intoOCA:18.0from
ferran-S73 wants to merge 1 commit intoOCA:18.0from
Conversation
pedrobaeza
reviewed
Mar 16, 2026
Member
pedrobaeza
left a comment
There was a problem hiding this comment.
Please remove the version from the commit message, and about the functionality, it's interesting, but please add all the stuff for the active field like banner.
a2c0a7d to
1605a13
Compare
Author
|
@pedrobaeza removed version from commit message + rebased to resolve conflicts. As per the banner, are you talking about the ribbon with the text "archived" that is shown in some views? If that is the case I can't add it here since there is no actual form view for the |
Member
|
OK, if all is handled from the list view, then it should be handled in a similar way to crons, that all are shown through a default filter, and an extra one should be to have a pill to identify the active/inactive ones in a column. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even with odoo neutralize script executed reports where still being sent to printers.
On one side the search for users behaviours finds them even though the printers where deactivated, thus the need to a add an active field to this model and set it to false in the script.
On the other side the general printer configured in a report needs to be cleaned or it will otherwise be found and used for printing.