Skip to content

[18.0][MIG] project_portal_properties#1693

Open
etobella wants to merge 3 commits intoOCA:18.0from
dixmit:18.0-add-properties
Open

[18.0][MIG] project_portal_properties#1693
etobella wants to merge 3 commits intoOCA:18.0from
dixmit:18.0-add-properties

Conversation

@etobella
Copy link
Copy Markdown
Member

Migration to 18.0

REquires OCA/web#3481

@luisDIXMIT

Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no fields values are displayed in portal. What is wrong?

Image Image

@etobella
Copy link
Copy Markdown
Member Author

I will check, thanks for the comments

@luisDIXMIT
Copy link
Copy Markdown

I will check, thanks for the comments

Sorry for the noise, mate. I realized I wasn’t looking at the same task, so it’s normal that the value wasn’t shown.

Copy link
Copy Markdown

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review and tested locally with the dependencies. LGTM!

Copy link
Copy Markdown
Member

@CristianoMafraJunior CristianoMafraJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants