[FIX] base,base_address_city: double parent_id in view#901
Open
remi-filament wants to merge 1 commit intoOCA:12.0from
Open
[FIX] base,base_address_city: double parent_id in view#901remi-filament wants to merge 1 commit intoOCA:12.0from
remi-filament wants to merge 1 commit intoOCA:12.0from
Conversation
Author
|
Fixed in Odoo 14.0 with odoo@526bfca |
Member
|
The Odoo fix seems more sophisticated than this one. Can you maybe backport that instead of this? |
Author
|
my bad, I mixed things up, this issue is still not fixed in Odoo... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses: Issue #34405, reverts and fix #34498 : enforce parent_id domain and placeholder on partner form view when base_address_city is installed
Current behavior before PR: with implementation of #34498, parent_id field is present twice in partner form view with different attributes / options, and therefore no domain / placeholder is enforced on parent_id field (you can therefore select parent among all possible partners, not only among company type ones and placeholder disappeared).
Desired behavior after PR is merged: Bring back correct domain / placeholder / options on parent_id field on partner form views
PR pushed to Odoo in parallel on 9th Jan 2020 (#43068)
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr