add convergence tests for Theseus.jl and fix bugs#79
Merged
Conversation
|
Once the build has completed, you can preview your PR at this URL: https://NumericalMathematics.github.io/Ariadne.jl/previews/PR79/ in a couple of minutes. |
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
ranocha
changed the title
vchuravy
approved these changes
Dec 16, 2025
Member
|
1.10 doesn't use sources, so the test here are run against the releases version of Theseus |
ranocha
commented
Dec 16, 2025
Member
Author
But Theseus.jl is not registered... |
Member
|
Sorry against the release version of Ariadne, so we need a dev step here. |
Member
Author
|
Thanks, this looks good! Please merge the PR when CI passes 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered some erratic behavior while implementing the convergence tests (see broken tests and new issues).
@vchuravy How do we have to modify the CI setup to run the tests and track coverage?