Skip to content

Add the xxlvw extension usage notes for the vdsmacini instruction.#58

Merged
fanghuaqi merged 1 commit intomasterfrom
toolchain-dev-1121
Nov 21, 2025
Merged

Add the xxlvw extension usage notes for the vdsmacini instruction.#58
fanghuaqi merged 1 commit intomasterfrom
toolchain-dev-1121

Conversation

@dongyasun
Copy link
Contributor

@dongyasun dongyasun commented Nov 21, 2025

为xxlvw 扩展 vdsmacini 指令补充使用说明,强调目前需要加上 volatile 关键字才能保证程序绝对正确


Important

Add documentation note on using volatile with vdsmacini instruction in nuclei_xxlvw.rst to prevent optimization issues.

  • Documentation:
    • Update nuclei_xxlvw.rst to include a note on using volatile with vdsmacini instruction to prevent optimization issues.
    • Example in Examples section updated to use volatile with vint32m1_t tmp for vdsmacini usage.

This description was created by Ellipsis for e1f3bc7. You can customize this summary. It will automatically update as commits are pushed.

Signed-off-by: dysun <sundongya@nucleisys.com>
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to e1f3bc7 in 1 minute and 29 seconds. Click for details.
  • Reviewed 29 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. source/toolchain/gnu/nuclei_xxlvw.rst:209
  • Draft comment:
    Documentation update: The note now clearly states that if the intrinsic’s return value is unused, it must be declared with 'volatile' to prevent optimization at higher levels (-O2+).
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. source/toolchain/gnu/nuclei_xxlvw.rst:722
  • Draft comment:
    Example update: Declaring the temporary return value as 'volatile' ensures the vdsmacini instruction isn't optimized away. This aligns with the documentation note.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. source/toolchain/gnu/nuclei_xxlvw.rst:209
  • Draft comment:
    The term “intrinsic” is concatenated with surrounding Chinese text ("该指令的intrinsic使用时"). Consider adding spaces before and after “intrinsic” (e.g. "该指令的 intrinsic 使用时") for improved clarity.
  • Reason this comment was not posted:
    Comment was on unchanged code.
4. source/toolchain/gnu/nuclei_xxlvw.rst:211
  • Draft comment:
    The phrase "指令intrinsic" lacks a space between the Chinese and English words. For consistency and readability, consider updating it to "指令 intrinsic".
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_vkEj7dLAmWrU1pK5

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@fanghuaqi fanghuaqi merged commit a6b2811 into master Nov 21, 2025
1 check passed
@fanghuaqi fanghuaqi deleted the toolchain-dev-1121 branch November 21, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants