Add the xxlvw extension usage notes for the vdsmacini instruction.#58
Merged
Add the xxlvw extension usage notes for the vdsmacini instruction.#58
Conversation
Signed-off-by: dysun <sundongya@nucleisys.com>
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to e1f3bc7 in 1 minute and 29 seconds. Click for details.
- Reviewed
29lines of code in1files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. source/toolchain/gnu/nuclei_xxlvw.rst:209
- Draft comment:
Documentation update: The note now clearly states that if the intrinsic’s return value is unused, it must be declared with 'volatile' to prevent optimization at higher levels (-O2+). - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. source/toolchain/gnu/nuclei_xxlvw.rst:722
- Draft comment:
Example update: Declaring the temporary return value as 'volatile' ensures the vdsmacini instruction isn't optimized away. This aligns with the documentation note. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. source/toolchain/gnu/nuclei_xxlvw.rst:209
- Draft comment:
The term “intrinsic” is concatenated with surrounding Chinese text ("该指令的intrinsic使用时"). Consider adding spaces before and after “intrinsic” (e.g. "该指令的 intrinsic 使用时") for improved clarity. - Reason this comment was not posted:
Comment was on unchanged code.
4. source/toolchain/gnu/nuclei_xxlvw.rst:211
- Draft comment:
The phrase "指令intrinsic" lacks a space between the Chinese and English words. For consistency and readability, consider updating it to "指令 intrinsic". - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_vkEj7dLAmWrU1pK5
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为xxlvw 扩展 vdsmacini 指令补充使用说明,强调目前需要加上 volatile 关键字才能保证程序绝对正确
Important
Add documentation note on using
volatilewithvdsmaciniinstruction innuclei_xxlvw.rstto prevent optimization issues.nuclei_xxlvw.rstto include a note on usingvolatilewithvdsmaciniinstruction to prevent optimization issues.Examplessection updated to usevolatilewithvint32m1_t tmpforvdsmaciniusage.This description was created by
for e1f3bc7. You can customize this summary. It will automatically update as commits are pushed.