Skip to content

prettier-plugin-astro: update deprecated pnpm attributes#1394

Merged
NotAShelf merged 1 commit intoNotAShelf:mainfrom
joinemm:pr-fix-pnpm-deprecation-warning
Feb 4, 2026
Merged

prettier-plugin-astro: update deprecated pnpm attributes#1394
NotAShelf merged 1 commit intoNotAShelf:mainfrom
joinemm:pr-fix-pnpm-deprecation-warning

Conversation

@joinemm
Copy link
Contributor

@joinemm joinemm commented Feb 4, 2026

Building prettier-plugin-astro with latest nixpkgs unstable results in the following warnings:

trace: evaluation warning: pnpm.configHook: The package attribute is deprecated. Use the top-level pnpmConfigHook attribute instead
trace: evaluation warning: pnpm.fetchDeps: The package attribute is deprecated. Use the top-level fetchPnpmDeps attribute instead

Updated the package definition to use the new attributes, and override it to still force pnpm_9. This fixes the warnings but functionally the build is exactly the same (as this is what nixpkgs would replace them with internally anyway https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/tools/pnpm/generic.nix#L78)

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@NotAShelf
Copy link
Owner

Thank you for investigating this :)

@NotAShelf NotAShelf enabled auto-merge February 4, 2026 13:51
@NotAShelf NotAShelf merged commit 9da5d51 into NotAShelf:main Feb 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants