Skip to content

languages/python: expand LSPs#1320

Merged
NotAShelf merged 1 commit intoNotAShelf:mainfrom
machshev:python-lsps
Jan 13, 2026
Merged

languages/python: expand LSPs#1320
NotAShelf merged 1 commit intoNotAShelf:mainfrom
machshev:python-lsps

Conversation

@machshev
Copy link
Contributor

@machshev machshev commented Jan 7, 2026

Now that the new LSP API is available:

  • ruff: add support for the LSP as well as the existing formatter support
  • ty: new type checking from astral (promising new type checker)

Sanity Checking

  • I have updated the [changelog] as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in [hacking nvf]
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the [editorconfig] configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links) - there are 13 errors but I don't think I've introduced any of them?
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

🚀 Live preview deployed from c7fe3c1

View it here:

Debug Information

Triggered by: NotAShelf

HEAD at: python-lsps

Reruns: 1867

github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
@machshev machshev mentioned this pull request Jan 7, 2026
15 tasks
github-actions bot pushed a commit that referenced this pull request Jan 7, 2026
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick review comment, LGTM afterwards.

@sjcobb2022 sjcobb2022 mentioned this pull request Jan 9, 2026
17 tasks
@machshev machshev requested a review from NotAShelf January 12, 2026 11:38
github-actions bot pushed a commit that referenced this pull request Jan 12, 2026
@NotAShelf
Copy link
Owner

If you could resolve the merge conflict, this can be merged.

Now that the new LSP API is available add:

- ruff: add support for the LSP as well as the existing formatter support
- ty: new type checking from astral (promising new type checker)

Signed-off-by: David James McCorrie <[email protected]>
@machshev machshev force-pushed the python-lsps branch 2 times, most recently from fadfcd8 to 2dcdfd2 Compare January 13, 2026 12:08
github-actions bot pushed a commit that referenced this pull request Jan 13, 2026
@NotAShelf NotAShelf enabled auto-merge January 13, 2026 12:22
@NotAShelf NotAShelf changed the title python: expand LSPs languages/python: expand LSPs Jan 13, 2026
github-actions bot pushed a commit that referenced this pull request Jan 13, 2026
@NotAShelf NotAShelf merged commit b985468 into NotAShelf:main Jan 13, 2026
31 of 33 checks passed
@NotAShelf
Copy link
Owner

Thank you :)

@machshev machshev deleted the python-lsps branch January 13, 2026 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants