Open
Conversation
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I5c43bcf7331b19eaeb9628a4c2f76bfd6a6a6964
horriblename
reviewed
Dec 4, 2025
Collaborator
horriblename
left a comment
horriblename
left a comment
There was a problem hiding this comment.
Why not just split up supported-themes.nix into their own files, and have them define their options like normal modules?
# modules/plugins/theme/onedark.nix
{lib, config, ...}: {
options = {
enable = lib.mkEnableOption "...";
setupOpts = ...;
}
config.vim = {
startPlugins = ["onedark"];
luaConfigRC = "require'onedark'.setup(${...})";
};
}lazy-loading colorschemes is probably desirable since we're allowing multiple colorschemes
17 tasks
| }; | ||
|
|
||
| description = '' | ||
| New theme configuration option for v0.8 and above. This system allows |
Collaborator
There was a problem hiding this comment.
Suggested change
| New theme configuration option for v0.8 and above. This system allows | |
| New theme configuration option for v0.9 and above. This system allows |
horriblename
requested changes
Jan 27, 2026
Collaborator
horriblename
left a comment
horriblename
left a comment
There was a problem hiding this comment.
I changed my mind about splitting supporthed-themes.nix, I'll accept this aside from the "what" in the warnings section
(API looks good we'll just refactor later only if it starts being a problem)
|
|
||
| # We'd like to warn when the user is using a completely legacy configuration | ||
| warnings = let | ||
| # FIXME: what |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all @faukah's fault. I blame him for everything.
This PR finally refactors the theming module to be more configurable, namely in the sense that it can now:
setupOptsAPI that we've been pushingIn the light of the new API, the old options have been soft-deprecated. I would like to remove them altogether but I ran into some stupid issues with the warning messages, and could not be bothered with fixing each one of them one by one. Eventually we'll want to figure it out. Eventually.
Needs documentaton, and should be merged preferably after #1160 so we don't create more 9-sided merge conflicts.