Open
Conversation
caiodasilva2005
requested changes
Sep 5, 2025
| // STAGE 1 -- COUNTDOWN=charge, COUNTUP=settle | ||
| if (bmsdata->max_voltage.val < MAX_CHARGE_VOLT && !reached_stage_2) { | ||
| // BEGIN COUNTDOWN (first run only) | ||
| if (!is_timer_expired(&charger_settle_countdown_stage1)) { |
Contributor
There was a problem hiding this comment.
You should also add a !is_timer_active() in this block here because this will infinitely keep restarting the timer since completed will be false and then timer start time will reset
| reached_stage_2 = true; | ||
|
|
||
| // BEGIN COUNTDOWN (first run only) | ||
| if (!is_timer_expired(&charger_settle_countdown)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Explanation of changes goes here
Notes
Any other notes go here
Test Cases
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
Closes # (issue #)