Added LV box fan PWM msg object to the VCU CAN message, issue (#146)#51
Merged
Sakthi-PS7 merged 3 commits intomainfrom Apr 1, 2026
Merged
Added LV box fan PWM msg object to the VCU CAN message, issue (#146)#51Sakthi-PS7 merged 3 commits intomainfrom
Sakthi-PS7 merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new VCU CAN message definition for the LV Box fan PWM percentage (issue #146), while resolving a merge conflict.
Changes:
- Add CAN message
0xD5(LV Box Fan PWM) with an 8-bitfan_pwm_percentagepoint and correspondingVCU/LVBox/Fan_PWMfield. - Configure simulation bounds and frequency for the new signal.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved the merge conflict