Open
Conversation
caiodasilva2005
requested changes
Mar 28, 2026
Contributor
caiodasilva2005
left a comment
caiodasilva2005
left a comment
There was a problem hiding this comment.
awesome. I know this is prob not to be merged soon, but remove testing and commented threads before merging
| stream = pb_ostream_from_buffer(buffer, sizeof(buffer)); | ||
| if(status != U_SUCCESS) { | ||
| PRINTLN_WARNING("Failed to send Ethernet message after removing from outgoing queue: %ud", status); | ||
| if (status == 0x10002) { |
Contributor
There was a problem hiding this comment.
very nit but can we make a var for 0x10002. assuming that is mqtt disconnection return status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supports MQTT.