perf: lazy-load heavy dependencies in hardhat-utils#8201
Draft
tenderdeve wants to merge 1 commit intoNomicFoundation:mainfrom
Draft
perf: lazy-load heavy dependencies in hardhat-utils#8201tenderdeve wants to merge 1 commit intoNomicFoundation:mainfrom
tenderdeve wants to merge 1 commit intoNomicFoundation:mainfrom
Conversation
Convert top-level imports of 6 heavy dependencies to cached dynamic imports, loaded only when the consuming function is first called: - ethereum-cryptography (crypto.ts) — crypto init overhead - fast-equals (internal/lang.ts) — only needed for deepEqual - rfdc (internal/lang.ts) — only needed for deepClone - @streamparser/json-node (fs.ts) — only for readJsonFileAsStream - json-stream-stringify (fs.ts) — only for writeJsonFileAsStream - env-paths (internal/global-dir.ts) — rarely called at bootstrap Follows the cached await import() pattern already used by undici in this package. No public API changes. Fixes NomicFoundation#8162
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert top-level imports of 6 heavy dependencies to cached
await import(), loaded only on first use:ethereum-cryptographycrypto.tsfast-equalsinternal/lang.tsdeepEqualrfdcinternal/lang.tsdeepClone@streamparser/json-nodefs.tsreadJsonFileAsStreamjson-stream-stringifyfs.tswriteJsonFileAsStreamenv-pathsinternal/global-dir.tsFollows the cached
await import()pattern already established byundiciinrequest.tsin this same package. No public API changes — all consuming functions were already async.Fixes #8162
Test plan
npx hardhat --help— should be noticeably fasternpx hardhat compile— crypto functions still worknpx hardhat test— all tests passreadJsonFileAsStream/writeJsonFileAsStreamstill function