Skip to content

elmPackages.elm: don't check aeson#378618

Closed
mpscholten wants to merge 1 commit intoNixOS:haskell-updatesfrom
mpscholten:fix-elm
Closed

elmPackages.elm: don't check aeson#378618
mpscholten wants to merge 1 commit intoNixOS:haskell-updatesfrom
mpscholten:fix-elm

Conversation

@mpscholten
Copy link
Copy Markdown
Contributor

@mpscholten mpscholten commented Feb 1, 2025

Checking aeson fails as it depends on nothunks < 0.3, but we provide nothunks >= 0.3. Jailbreaking doesn't work in this context, so I disabled the tests instead.

I've also created an upstream fix via haskell/aeson#1129

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Checking aeson fails as it depends on nothunks < 0.3, but we provide nothunks >= 0.3. Jailbreaking doesn't work in this context, so I disabled the tests instead.
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 1, 2025
@mpscholten mpscholten marked this pull request as ready for review February 1, 2025 19:47
@wolfgangwalther
Copy link
Copy Markdown
Contributor

So this seems to be because of this:

https://github.com/haskell/aeson/blob/85c2da59d68953e48720e18f632689f385237e58/aeson.cabal#L242-L243

I think what we should do is to add the missing nothunks dependency (in the correct version) to configuration-ghc-9.2.x.nix, configuration-ghc-9.4.x.nix, configuration-ghc-9.6.x.nix. Alternatively, we could disable the checks there.

In any case, this same problem appears in haskell.packages.ghc96.aeson etc., so we should fix it at that level.

WDYT?

@sternenseemann
Copy link
Copy Markdown
Member

Running the test suite would be ideal, but I suspect providing nothunks in the correct versions would mean downgrading it globally since e.g. unordered-containers depends on nothunks which in turn is needed by aeson. I'm not sure what cabal will do actually if we disable the inconsistent dependency check when building a test suite with such a package…

@sternenseemann
Copy link
Copy Markdown
Member

Done in 1ee8e4b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants