Conversation
Member
|
@daringer What’s the status of this PR? |
Contributor
Author
|
good question - this just adds the failing test case and no solution for that - do we want to have test-cases included which always fail ? |
Member
|
Oh, I wasn’t aware that this is expected to fail currently. So we don’t set any mechanisms when generating keys? Is there an issue for that? Looking at the source code, I expected at least some mechanisms to be set. |
Contributor
Author
|
the test is currently not working as it's missing the prefix "0--" to select the key - will fix that first, but so far I remember I also checked the source here and couldn't find any obvious solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.