Open
Conversation
Allows selecting both files and folders at the same time to perform actions on. Selected files are either moved to clipboard for the `Cut`/`Copy` and `Paste` actions, or deleted with `Delete`. `Rename` action still only works on single file, but that file can be in the multi selection.
956MB
requested review from
HaxSam,
MatthewKuKanich,
Sil333033 and
WillyJL
as code owners
- New file list widget was created to show the to-be-deleted files on the delete screen, rather than just "Delete n files?" It's also scrollable. - 'Select' action menu option was removed from the favorites tab since favorites already have a mechanism for that stuff.
Member
Author
|
I updated the delete screen with a new file list widget. It's scrollable up/down but the files are obviously not selectable with a cursor or anything. They're just there as a visual confirmation of what you're about to delete. Of course it's up to whoever in charge whether it should be in there of not, but I think it's helpful. Fills out the empty space too. 
|
- File list now accounts for `.js` files and uses correct icon
- Using deselect (`left`) on a folder that itself wasn't selected but had selected children inside (any amount in any sub folders) would not deselect everything from that folder down. Meaning the steps to deselect a folders contents would be to select the folder itself with `right` then deselect with `left`, adding one unnecessary action to the process.
956MB
added a commit
that referenced
this pull request
Jan 2, 2026
956MB
added a commit
that referenced
this pull request
Jan 2, 2026
This branch consolidates several [PRs](https://github.com/Next-Flip/Momentum-Firmware/issues?q=is:pr+is:open+author:956MB) (UI fixes and additions) into a usable build. Flash space is extremely low as is, and excluding some weather stations and other SubGHz protocols is necessary to be able to fit these PRs and allow for further changes. The ones that have been *temporarily* excluded are hopefully uncommon or legacy protocols that won't be missed if you're using this branch. The point of this branch being primarily UI features. * #327 * #344 * #354 * #385 Excluded protocols: * Uncommon/Regional gate, garage, and alarm protocols: `nero_sketch`, `nero_radio`, `ido`, `kia`, `power_smart`, `doitrand`, `ansonic`, `smc5326`, `linear_delta3`, `dooya`, `kinggates_stylo_4k`, `dickert_mahs`, `hay21`, `feron`, `elplast`, `schrader_gg4`, `tpms_generic`. * Obscure weather-station protocols: `solight_te44`, `infactory`, `acurite_986`, `auriol_ahfl`, `auriol_hg0601a`, `emos_e601x`, `gt_wt_02`, `gt_wt_03`, `kedsum_th`, `nexus_th`, `oregon_v1`, `thermopro_tx4`, `tx_8300`, `vauno_en8822c`, `wendox_w6726`.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Addresses #254
As discussed in that issue, this implements multiple file/folder selection in the Archive file browser. With some personal design choices for the list selection indicators that can be changed if needed.
Cut,Copy,Paste,Delete)[+](for files or entire folders), or a number[2]to show the amount of selected files in a folder.Interface > File Browser > Selection Indicatorwas added to change which character is used in the selected file indicator:+,*or-. (These can also be changed or more added.)[3]indicator, the folder itself can be selected and all the files inside it are deselected and the folder shows a[+].select modeis also possible, but it works on one at a time. Not all the selected files.Keybinds for the "select mode" are as follows:
This set of keybinds allows for selecting files and folders the same way and the ability to enter folders for its contents. as mentioned in the issue comments.
Couple of other things I'd thought of doing but haven't yet (TODO):
Select"badge" text at the top of the status bar also show the amount of selected files, like thisSelect (4).Add a scrollable list to the delete screen when theres more than one file being deleted. Gives you a second to see the files about to be deleted rather than "Delete 5 files?".Screenshots
Delete files in multiple folders
Copy folder and file
Copy files and delete
Rename selected file then delete
Nested path error dialog
For the reviewer